On 11/12/2011 05:54 PM, Malcolm Priestley wrote:
It is noticed that sometimes the device fails to download parts of the firmware.
Since there is no ack from firmware write a 250u second delay has been added.
Signed-off-by: Malcolm Priestley<tvboxspy@xxxxxxxxx>
---
drivers/media/dvb/dvb-usb/af9015.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/media/dvb/dvb-usb/af9015.c b/drivers/media/dvb/dvb-usb/af9015.c
index c6c275b..dc6e4ec 100644
--- a/drivers/media/dvb/dvb-usb/af9015.c
+++ b/drivers/media/dvb/dvb-usb/af9015.c
@@ -698,6 +698,7 @@ static int af9015_download_firmware(struct usb_device *udev,
err("firmware download failed:%d", ret);
goto error;
}
+ udelay(250);
}
/* firmware loaded, request boot */
That sleep is not critical as all, so defining it as udelay() is wrong
in my understanding. Refer Kernel documentation about delays.
regards
Antti
--
http://palosaari.fi/
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
