Hi Thomas, On 10/15/2011 11:38 PM, Thomas Jarosch wrote: > Detected by "cppcheck". > > This time with "Signed-off-by" line. > > Signed-off-by: Thomas Jarosch <thomas.jarosch@xxxxxxxxxxxxx> Acked-by: Sylwester Nawrocki <s.nawrocki@xxxxxxxxxxx> > --- > drivers/media/video/m5mols/m5mols_core.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/media/video/m5mols/m5mols_core.c b/drivers/media/video/m5mols/m5mols_core.c > index fb8e4a7..e485e9e 100644 > --- a/drivers/media/video/m5mols/m5mols_core.c > +++ b/drivers/media/video/m5mols/m5mols_core.c > @@ -333,7 +333,7 @@ int m5mols_mode(struct m5mols_info *info, u8 mode) > int ret = -EINVAL; > u8 reg; > > - if (mode < REG_PARAMETER && mode > REG_CAPTURE) > + if (mode < REG_PARAMETER || mode > REG_CAPTURE) > return ret; > > ret = m5mols_read_u8(sd, SYSTEM_SYSMODE, ®); -- Regards, Sylwester -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html