On 10/30/2011 10:03 PM, Piotr Chmura wrote: > W dniu 18.10.2011 21:46, Piotr Chmura pisze: >> Patch taken from http://kernellabs.com/hg/~dheitmueller/v4l-dvb-as102-2/ >> >> Changes made by me: >> 1. Driver moved from media/dvb to staging/media >> 2. Removed Makefile/Kconfig - it doesn't compile in current tree > (...) >> + >> +/* >> + * Note: >> + * - in AS102 SNR=MER >> + * - the SNR will be returned in linear terms, i.e. not in dB >> + * - the accuracy equals ±2dB for a SNR range from 4dB to 30dB >> + * - the accuracy is>2dB for SNR values outside this range >> + */ > > I found another issue here. > In this comment "±" is from upper ASCII (0xF1). Should I change it into sth. > like "+/-" in this patch (1/14) or leave it and just resend without "Â" > (wasn't there in original patch, don't know where it came from) ? I collected all your patches (1..14/14, as we agreed in private), did a bit of cleanup myself, re-edited the changelogs and I'm going to post the series which is hopefully ready for initial pull into staging/media. I've also removed that odd  character right from the first patch. > > Peter > > P.S. Thanks to Sylwester Nawrocki for pointing me out, that there is something > wrong with patch 6/14, which was caused by this comment in 1/14. --- Regards, Sylwester -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
