Re: [PATCH] media: vb2: reset queued list on REQBUFS(0) call

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi, Marek
   Why not call vb2_queue_release directly in reqbufs(0) instead of
__vb2_queue_free, which could clear queued_count as well?

Angela
Best Regards

On Tue, Oct 25, 2011 at 3:59 PM, Marek Szyprowski
<m.szyprowski@xxxxxxxxxxx> wrote:
> Queued list was not reset on REQBUFS(0) call. This caused enqueuing
> a freed buffer to the driver.
>
> Reported-by: Angela Wan <angela.j.wan@xxxxxxxxx>
> Signed-off-by: Marek Szyprowski <m.szyprowski@xxxxxxxxxxx>
> Signed-off-by: Kyungmin Park <kyungmin.park@xxxxxxxxxxx>
> ---
>  drivers/media/video/videobuf2-core.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/media/video/videobuf2-core.c
> b/drivers/media/video/videobuf2-core.c
> index 3015e60..5722b81 100644
> --- a/drivers/media/video/videobuf2-core.c
> +++ b/drivers/media/video/videobuf2-core.c
> @@ -254,6 +254,7 @@ static void __vb2_queue_free(struct vb2_queue *q)
>
>        q->num_buffers = 0;
>        q->memory = 0;
> +       INIT_LIST_HEAD(&q->queued_list);
>  }
>
>  /**
> --
> 1.7.1
>
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux