Thank you for the suggestions (both of you). I'll submit a pull request by this weekend (as I want to test it again in Ubuntu 11.10 just to make sure everything works). And for Mauro, is there a direct link to the scripts? I looked for them after the last time I emailed, but couldn't find them (or I wasn't looking in the right place). Have a great day:) Patrick. On 10/19/2011 10:44 PM, Mauro Carvalho Chehab wrote: > Em 19-10-2011 11:57, Devin Heitmueller escreveu: >> Hi Patrick, >> >> On Wed, Oct 19, 2011 at 8:36 AM, Patrick Dickey <pdickeybeta@xxxxxxxxx> wrote: >>> I'm posting this question under this thread because the subject pertains >>> to the question (in that I'm asking about staging and about the PCTV 80e >>> drivers). >> >> You should definitely be looking at the "as102" thread that is >> currently going on this mailing list. Piotr is actually going through >> the same process as you are (he is working on upstreaming the as102 >> driver from a kernellabs.com tree). He made some pretty common >> mistakes (all perfectly understandable), and your reading the thread >> might help you avoid them (and having to redo your patch series). >> >>> I started cleaning up the drx39xx* drivers for the PCTV-80e and have >>> them in a github repository. Ultimately I want to send a pull request, >>> so other people can finish the cleaning (as I'm not comfortable with >>> pulling out the #ifdef statements myself). >> >> You should definitely ask Mauro how he expects to do a staging driver >> for a demodulator before you do any further work. The staging tree >> works well for bridge drivers, but demod drivers such as the drx >> require code in the bridge driver (the em28xx in this case), so it's >> not clear how you would do staging for a product where the bridge >> driver isn't in staging as well. The answer to that question will >> likely guide you in how to get the driver into staging. > > Ah yes, good point. Well, just submit it as if it should be added at > the right place, but putting the Kconfig changes in separate. If this > driver is not that different than the other drx drivers, I may try to > find some time to fix it on the same way. > > You may also take a look at the history for the drx-k merging patches. > I basically wrote a few small perl scripts to correct coding style, and > a few manual work. > >> >> If you have specific questions regarding anything you see in the >> driver, let me know. I don't have much time nowadays but will find >> the time if you ask concise questions. >> >> Good luck. It will be great to finally see this merged upstream. >> >> Devin >> > -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
