Hi Javier, Thanks for the patches. On Sunday 09 October 2011 04:37:31 Javier Martinez Canillas wrote: > This patch-set aims to add support to the ISP CCDC driver to process > interlaced video data in ITU-R BT.656 format. > > The patch-set contains the following patches: > > [PATCH 1/2] omap3isp: video: Decouple buffer obtaining and set ISP entities > format [PATCH 2/2] omap3isp: ccdc: Add support to ITU-R BT.656 video data > format > > The first patch decouples next frame buffer obtaining from the last frame > buffer releasing. This change is needed by the second patch that moves > most of the CCDC buffer management logic to the VD1 interrupt handler. > > This patch-set is a proof-of-concept and was only compile tested since I > don't have the hardware to test right now. It is a forward porting, on top > of Laurent's omap3isp-omap3isp-yuv tree, of the changes we made to the ISP > driver to get interlaced video working. > > Also, the patch will brake other configurations since the resizer and > previewer also make use of omap3isp_video_buffer() function that now has a > different semantic. That's an issue you need to address :-) > I'm posting even when the patch-set is not in a merge-able state so you can > review what we were doing and make comments. You should split your patches differently. Even if we ignore the above issue, your first patch will break the CCDC. In order to ease bissection patches should be self-contained and not introduce regressions if possible. Please see my comments to the second patch. > These are not all our changes since we also modified the ISP to forward the > [G | S]_FMT and [G | S]_STD V4L2 ioctl commands to the TVP5151 and to only > copy the active lines, but those changes are not relevant with the ghosting > effect. With these changes we could get the 25 fps but with some sort of > artifacts on the images. -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
