Re: [PATCH 3/3] [media] tvp5150: Migrate to media-controller framework and add video format detection

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Javier,

On Tuesday 04 October 2011 00:37:27 Javier Martinez Canillas wrote:
> Hello,
> 
> Reading the last emails I understand that still isn't a consensus on
> the way this has to be made. If it has to be implemented at the video
> device node level or at the sub-device level. And if it has to be made
> in kernel or user-space.
> 
> On Mon, Oct 3, 2011 at 11:56 PM, Mauro Carvalho Chehab wrote:
> > Em 03-10-2011 18:44, Laurent Pinchart escreveu:
> >> On Monday 03 October 2011 21:16:45 Mauro Carvalho Chehab wrote:
> >>> Em 03-10-2011 08:53, Laurent Pinchart escreveu:
> >>>> On Monday 03 October 2011 11:53:44 Javier Martinez Canillas wrote:

[snip]

> >> With the OMAP3 ISP, which is I believe what Javier was asking about, the
> >> application will set the format on the OMAP3 ISP resizer input and
> >> output pads to configure scaling.
> 
> Yes, that was my question about. But still is not clear to me if
> configuring the ISP resizer input and output pads with different frame
> sizes automatically means that I have to do the scale or this has to
> be configured using a S_FMT ioctl to the /dev/video? node.

The resizer is completely controlled through the formats at its sink and 
source pads. It will scale the image to achieve what is configured at its 
source pad (with x1/4..x4 limits in the zoom ratio).

> Basically what I don't know is when I have to modify the pipeline graph
> inside the ISP driver and when this has to be made from user-space via MCF.

The pipeline needs to be configured before you start video capture. This means 
setting the links according to your use case, and configuring the formats on 
pads. You will then be able to use a pure V4L2 application to capture video.

> > The V4L2 API doesn't tell where a function like scaler will be
> > implemented. So, it is fine to implement it at tvp5151 or at the omap3
> > resizer, when a V4L2 call is sent.
> 
> I don't think I can do the cropping and scaling in the tvp5151 driver
> since this is a dumb device, it only spits bytes via its parallel
> interface. The actual buffer is inside the ISP.

Cropping might be possible (I'm not too familiar with the tvp5151), but 
scaling indeed isn't. That doesn't matter much though.

-- 
Regards,

Laurent Pinchart
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux