Re: [PATCHv2 5/8] [media] pvrusb2: initialize standards mask before detecting standard

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Mauro:

With the line you've just added, then the " = arg" assignment in the 
immediate prior line is effectively dead code.  Try this instead:

 	case VIDIOC_QUERYSTD:
 	{
-		v4l2_std_id *std = arg;
+		v4l2_std_id *std = V4L2_STD_ALL;
 		ret = pvr2_hdw_get_detected_std(hdw, std);
 		break;
 	}

  -Mike


On Tue, 4 Oct 2011, Mauro Carvalho Chehab wrote:

> Signed-off-by: Mauro Carvalho Chehab <mchehab@xxxxxxxxxx>
> ---
>  drivers/media/video/pvrusb2/pvrusb2-v4l2.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/media/video/pvrusb2/pvrusb2-v4l2.c b/drivers/media/video/pvrusb2/pvrusb2-v4l2.c
> index 0d029da..ce7ac45 100644
> --- a/drivers/media/video/pvrusb2/pvrusb2-v4l2.c
> +++ b/drivers/media/video/pvrusb2/pvrusb2-v4l2.c
> @@ -230,6 +230,7 @@ static long pvr2_v4l2_do_ioctl(struct file *file, unsigned int cmd, void *arg)
>  	case VIDIOC_QUERYSTD:
>  	{
>  		v4l2_std_id *std = arg;
> +		*std = V4L2_STD_ALL;
>  		ret = pvr2_hdw_get_detected_std(hdw, std);
>  		break;
>  	}
> 

-- 

Mike Isely
isely @ isely (dot) net
PGP: 03 54 43 4D 75 E5 CC 92 71 16 01 E2 B5 F5 C1 E8
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux