Re: [PATCH 2/5] doc: v4l: add binary images for selection API

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Friday, September 30, 2011 18:54:01 Mauro Carvalho Chehab wrote:
> Em 29-09-2011 11:22, Tomasz Stanislawski escreveu:
> > This patch adds images in binary format for the V4L2 selection API.
> 
> Please, just fold with the docbook patch on a next submission. Also, please
> put the docbook patch at the beginning of the series, since this is the most
> important patch on this series, as the other ones can only be understandable
> after reading the docbook.

Mauro, I much prefer these binary patches in a separate patch when it comes
to reviewing. I find it quite annoying having to delete 3000-odd lines of b64
nonsense just to get to the actual xml patches. And you might even miss an
important patch if it is in between two binary patches.

For a git pull request I don't care, but for inline patches it makes my life
easier.

Tomasz split it up on my suggestion, actually.

Regards,

	Hans

> 
> Thanks!
> Mauro
> > 
> > Signed-off-by: Tomasz Stanislawski <t.stanislaws@xxxxxxxxxxx>
> > Signed-off-by: Kyungmin Park <kyungmin.park@xxxxxxxxxxx>
> > ---
> >  Documentation/DocBook/media/constraints.png.b64 |  134 +
> >  Documentation/DocBook/media/selection.png.b64   | 2937 +++++++++++++++++++++++
> >  2 files changed, 3071 insertions(+), 0 deletions(-)
> >  create mode 100644 Documentation/DocBook/media/constraints.png.b64
> >  create mode 100644 Documentation/DocBook/media/selection.png.b64
> > 
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux