Hi The following change set is a third version of the subdev driver for S5K6AAFX sensor. Changes since v2: - addressed Sakari's comments: use lower case used for all hexadecimal numbers, use usleep_range instead of udelay, move mirror flags to s5k6aa struct, remove static data from s5k6aa_preset struct - minimize I2C access in S_CTRL handler - return constant TRY format in subdev open() - added set_crop/get_crop ops - fixed bugs in the internal PLL/clocks setup functions resulting in the firmware rejecting whole user configuration in some cases - added driver's private controls for RGB component gains - corrections per Hans' suggestions: removed unneeded v4l2_* subdev controls ops - patch 2/2 - no changes Changes since v1: - improved s5k6aa_initialize_ctrls() - fixed pixel resolution update issue which resulted in cropping where scaling was expected - used V4L2_COLORFX_SKY_BLUE instead of V4L2_COLORFX_ALPHA - dropped patch adding V4L2_COLORFX_AQUA entry for V4L2_CID_COLORFX control - patch 2/2 - no changes Thanks again for all the review comments. Sylwester Nawrocki (2): v4l: Add AUTO option for the V4L2_CID_POWER_LINE_FREQUENCY control v4l: Add v4l2 subdev driver for S5K6AAFX sensor Documentation/DocBook/media/v4l/controls.xml | 5 +- drivers/media/video/Kconfig | 7 + drivers/media/video/Makefile | 1 + drivers/media/video/s5k6aa.c | 1690 ++++++++++++++++++++++++++ drivers/media/video/v4l2-ctrls.c | 1 + include/linux/videodev2.h | 1 + include/media/s5k6aa.h | 51 + 7 files changed, 1754 insertions(+), 2 deletions(-) create mode 100644 drivers/media/video/s5k6aa.c create mode 100644 include/media/s5k6aa.h Regards, -- Sylwester Nawrocki Samsung Poland R&D Center -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html