Hi Hans, Thanks for the review. On Monday 26 September 2011 12:21:11 Hans Verkuil wrote: > On Friday, September 09, 2011 17:52:49 Laurent Pinchart wrote: [snip] > > +/* Register definitions */ > > + > > +/* Read-only Design info register: Reset state: xxxx 0001 - for Senna */ > > What's 'Senna'? I see this at several places in this driver. It's probably > a code name of some sort, but this needs some explanation. > > <...cut...> My bad. I'll fix it. > > + > > + /* V4L2_CID_FLASH_INDICATOR_INTENSITY */ > > + v4l2_ctrl_new_std(&flash->ctrls, &as3645a_ctrl_ops, > > + V4L2_CID_FLASH_INDICATOR_INTENSITY, > > + AS3645A_INDICATOR_INTENSITY_MIN, > > + AS3645A_INDICATOR_INTENSITY_MAX, > > + AS3645A_INDICATOR_INTENSITY_STEP, > > + AS3645A_INDICATOR_INTENSITY_MIN); > > + > > + flash->indicator_current = 0; > > + > > + /* V4L2_CID_FLASH_FAULT */ > > + ctrl = v4l2_ctrl_new_std(&flash->ctrls, &as3645a_ctrl_ops, > > + V4L2_CID_FLASH_FAULT, 0, > > + V4L2_FLASH_FAULT_OVER_VOLTAGE | > > + V4L2_FLASH_FAULT_TIMEOUT | > > + V4L2_FLASH_FAULT_OVER_TEMPERATURE | > > + V4L2_FLASH_FAULT_SHORT_CIRCUIT, 0, 0); > > + if (ctrl != NULL) > > + ctrl->is_volatile = 1; > > + > > + /* V4L2_CID_FLASH_READY */ > > + ctrl = v4l2_ctrl_new_std(&flash->ctrls, &as3645a_ctrl_ops, > > + V4L2_CID_FLASH_READY, 0, 1, 1, 1); > > + if (ctrl != NULL) > > + ctrl->is_volatile = 1; > > Note that 'is_volatile' is now replaced by the new V4L2_CTRL_FLAG_VOLATILE > flag for ctrl->flags. You'll need to redo your patch. In which kernel version will that be included ? -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
