Re: [PATCH v3 4/4] OMAP_VOUT: Don't trigger updates in omap_vout_probe

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 2011-09-27 at 12:32 +0530, Archit Taneja wrote:
> On Tuesday 27 September 2011 11:40 AM, Valkeinen, Tomi wrote:
> > On Mon, 2011-09-26 at 17:29 +0530, Archit Taneja wrote:
> >> Remove the code in omap_vout_probe() which calls display->driver->update() for
> >> all the displays. This isn't correct because:
> >>
> >> - An update in probe doesn't make sense, because we don't have any valid content
> >>    to show at this time.
> >> - Calling update for a panel which isn't enabled is not supported by DSS2. This
> >>    leads to a crash at probe.
> >
> > Calling update() on a disabled panel should not crash... Where is the
> > crash coming from?
> 
> you are right, the crash isn't coming from the updates. I see the crash 
> when we have 4 dss devices in our board file. The last display pointer 
> is corrupted in that case. I'm trying to figure out why.

Could be totally unrelated, but does the V4L2 driver make sure that the
used dss devices have a driver loaded?

OMAPFB previously refused to start if all the devices do not have a
driver, but nowadays it starts fine by skipping the devices without a
driver.

 Tomi


--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux