On 09/21/2011 05:22 PM, Mauro Carvalho Chehab wrote:
> Em 19-01-2011 23:44, Sylwester Nawrocki escreveu:
>> s_stream does nothing in current form so remove it.
>>
>> Signed-off-by: Sylwester Nawrocki <s.nawrocki@xxxxxxxxxxx>
>> Signed-off-by: Kyungmin Park <kyungin.park@xxxxxxxxxxx>
>> ---
>> drivers/media/video/sr030pc30.c | 6 ------
>> 1 files changed, 0 insertions(+), 6 deletions(-)
>>
>> diff --git a/drivers/media/video/sr030pc30.c b/drivers/media/video/sr030pc30.c
>> index c901721..e1eced1 100644
>> --- a/drivers/media/video/sr030pc30.c
>> +++ b/drivers/media/video/sr030pc30.c
>> @@ -714,11 +714,6 @@ static int sr030pc30_base_config(struct v4l2_subdev *sd)
>> return ret;
>> }
>>
>> -static int sr030pc30_s_stream(struct v4l2_subdev *sd, int enable)
>> -{
>> - return 0;
>> -}
>> -
>> static int sr030pc30_s_power(struct v4l2_subdev *sd, int on)
>> {
>> struct i2c_client *client = v4l2_get_subdevdata(sd);
>> @@ -761,7 +756,6 @@ static const struct v4l2_subdev_core_ops sr030pc30_core_ops = {
>> };
>>
>> static const struct v4l2_subdev_video_ops sr030pc30_video_ops = {
>> - .s_stream = sr030pc30_s_stream,
>> .g_mbus_fmt = sr030pc30_g_fmt,
>> .s_mbus_fmt = sr030pc30_s_fmt,
>> .try_mbus_fmt = sr030pc30_try_fmt,
>
> Hmm...
> this patch[1] were never merged. It seems a cleanup, though.
>
> Care to review it?
Indeed, it is still worth to apply. There was some ongoing work
at the control framework and other patches form this series need some
more modifications. But this one alone can be merged.
>
> Thanks!
> Mauro
>
> [1] http://patchwork.linuxtv.org/patch/5631/
>
>
Thank you,
--
Sylwester Nawrocki
Samsung Poland R&D Center
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
