Hi Sylwester, Thanks for the patch. On Monday 19 September 2011 19:07:55 Sylwester Nawrocki wrote: > FIELD is an Even/Odd field selection signal, as specified in ITU-R BT.601 > standard. Add corresponding flag for configuring the FIELD signal polarity. > Also add a comment about usage of V4L2_MBUS_[HV]SYNC* flags for the > hardware that uses [HV]REF signals. I like this approach better. > Signed-off-by: Sylwester Nawrocki <s.nawrocki@xxxxxxxxxxx> > Signed-off-by: Kyungmin Park <kyungmin.park@xxxxxxxxxxx> > --- > Resending with proper bit assignment. > > --- > include/media/v4l2-mediabus.h | 11 +++++++++-- > 1 files changed, 9 insertions(+), 2 deletions(-) > > diff --git a/include/media/v4l2-mediabus.h b/include/media/v4l2-mediabus.h > index 6114007..f3a61ab 100644 > --- a/include/media/v4l2-mediabus.h > +++ b/include/media/v4l2-mediabus.h > @@ -22,8 +22,12 @@ > */ > #define V4L2_MBUS_MASTER (1 << 0) > #define V4L2_MBUS_SLAVE (1 << 1) > -/* Which signal polarities it supports */ > -/* Note: in BT.656 mode HSYNC and VSYNC are unused */ > +/* > + * Signal polarity flags > + * Note: in BT.656 mode HSYNC, FIELD, and VSYNC are unused > + * V4L2_MBUS_[HV]SYNC_* flags should be also used for specifying > + * configuration of hardware that uses [HV]REF signals > + */ > #define V4L2_MBUS_HSYNC_ACTIVE_HIGH (1 << 2) > #define V4L2_MBUS_HSYNC_ACTIVE_LOW (1 << 3) > #define V4L2_MBUS_VSYNC_ACTIVE_HIGH (1 << 4) > @@ -32,6 +36,9 @@ > #define V4L2_MBUS_PCLK_SAMPLE_FALLING (1 << 7) > #define V4L2_MBUS_DATA_ACTIVE_HIGH (1 << 8) > #define V4L2_MBUS_DATA_ACTIVE_LOW (1 << 9) > +/* Field selection signal for interlaced scan mode */ > +#define V4L2_MBUS_FIELD_ACTIVE_HIGH (1 << 10) > +#define V4L2_MBUS_FIELD_ACTIVE_LOW (1 << 11) What does this mean ? The FIELD signal is used to select between odd and even fields. Does "active high" mean that the field is odd or even when the signal has a high level ? The comment should make it explicit, or we could even rename those two constants to FIELD_ODD_HIGH/FIELD_ODD_LOW (or FIELD_EVEN_HIGH/FIELD_EVEN_LOW). > /* Serial flags */ > /* How many lanes the client can use */ -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
