Re: [PATCH 2/3] soc-camera: mt9t112: modify delay time after initialize

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Morimoto-san

Thanks for your reply.

On Mon, 19 Sep 2011, Kuninori Morimoto wrote:

> Hi Guennadi, all
> 
> > > > mt9t112 camera needs 100 milliseconds for initializing
> > > > Special thanks to Phil
> > > > 
> > > > Signed-off-by: Kuninori Morimoto <morimoto.kuninori@xxxxxxxxxxx>
> > > > Reported-by: Phil Edworthy <Phil.Edworthy@xxxxxxxxxxx>
> > > > ---
> > > >  drivers/media/video/mt9t112.c |    2 +-
> > > >  1 files changed, 1 insertions(+), 1 deletions(-)
> > > > 
> > > > diff --git a/drivers/media/video/mt9t112.c b/drivers/media/video/mt9t112.c
> > > > index 7438f8d..e581d8a 100644
> > > > --- a/drivers/media/video/mt9t112.c
> > > > +++ b/drivers/media/video/mt9t112.c
> > > > @@ -885,7 +885,7 @@ static int mt9t112_s_stream(struct v4l2_subdev *sd, int enable)
> > > >  		/* Invert PCLK (Data sampled on falling edge of pixclk) */
> > > >  		mt9t112_reg_write(ret, client, 0x3C20, param);
> > > >  
> > > > -		mdelay(5);
> > > > +		mdelay(100);
> > > >  
> > > >  		priv->flags |= INIT_DONE;
> > > >  	}
> > > 
> > > Hi Guennadi,
> > > 
> > > What's the status of this patch?
> > > 
> > > It applies ok for me, and I couldn't find any reference at the
> > > ML why it was not applied yet.
> > 
> > Hm, yeah... Looks like also this patch:
> > 
> > > Subject: [PATCH 3/3] soc-camera: mt9t112: The flag which control camera-init is removed
> > > 
> > > mt9t112 should always be initialized when camera start.
> > > Because current driver doesn't run this operation,
> > > it will be un-stable if user side player run open/close several times.
> > > Special thanks to Namiki-san
> > > 
> > > Signed-off-by: Kuninori Morimoto <morimoto.kuninori@xxxxxxxxxxx>
> > > Reported-by: Takashi Namiki <Takashi.Namiki@xxxxxxxxxxx>
> > 
> > has not been applied nor discussed on the list... For patches that old I 
> > would tend to say: if the author / submitter didn't re-submit, then, 
> > probably, patches aren't relevant anymore... Although it is quite 
> > possible, that I failed to process them back then. Morimoto-san, do you 
> > have any information on these patches? Have these problems been solved 
> > somehow, so that the patches have become obsolete, or are the problems, 
> > that they address, still there?
> 
> This patch is needed for mt9t112 camera initialize.
> I thought that it was already applied.

Which patch do you mean? Patch 2/3, or 3/3, or both are needed?

Thanks
Guennadi
---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux