davinci-linux-open-source-bounces@xxxxxxxxxxxxxxxxxxxx wrote: > This patch implements the core additions to the display driver, > mainly controlling the VENC and other encoders for dm365. > This patch also includes addition of amplifier subdevice to the > vpbe driver and interfacing with venc subdevice. One small nit. Sorry about the probably broken quoting to follow. > @@ -704,6 +717,39 @@ static int vpbe_initialize(struct device > *dev, struct vpbe_device *vpbe_dev) > + v4l2_warn(&vpbe_dev->v4l2_dev, "non-i2c amplifiers" > + " currently not supported"); > + } > + } else > + vpbe_dev->amp = NULL; iirc this is not kernel style, if the "then" side of an if needs braces then the "else" side must have them too. -- Jon Povey jon.povey@xxxxxxxxxxxxxxx Racelogic is a limited company registered in England. Registered number 2743719 . Registered Office Unit 10, Swan Business Centre, Osier Way, Buckingham, Bucks, MK18 1TB . The information contained in this electronic mail transmission is intended by Racelogic Ltd for the use of the named individual or entity to which it is directed and may contain information that is confidential or privileged. If you have received this electronic mail transmission in error, please delete it from your system without copying or forwarding it, and notify the sender of the error by reply email so that the sender's address records can be corrected. The views expressed by the sender of this communication do not necessarily represent those of Racelogic Ltd. Please note that Racelogic reserves the right to monitor e-mail communications passing through its network -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
