On Mon, Sep 19, 2011 at 12:53:07AM +0200, Laurent Pinchart wrote: > Hi Martin, > > Thanks for the patch. > > On Saturday 17 September 2011 11:26:36 Martin Hostettler wrote: > > Ioctls on the subdevs node currently don't dispatch the register access > > debug driver callbacks. Add the dispatching with the same security checks > > are for non subdev video nodes (i.e. only capable(CAP_SYS_ADMIN may call > > the register access ioctls). > > Can we get your SoB line ? If you resubmit the patch, please fold the commit > message at 72 columns to keep git happy. Yes, of course. Seems i forgot it. > > > --- > > drivers/media/video/v4l2-subdev.c | 20 ++++++++++++++++++++ > > 1 files changed, 20 insertions(+), 0 deletions(-) > > > > diff --git a/drivers/media/video/v4l2-subdev.c > > b/drivers/media/video/v4l2-subdev.c index b7967c9..8bf8397 100644 > > --- a/drivers/media/video/v4l2-subdev.c > > +++ b/drivers/media/video/v4l2-subdev.c > > @@ -25,6 +25,7 @@ > > #include <linux/types.h> > > #include <linux/videodev2.h> > > > > +#include <media/v4l2-chip-ident.h> > > Is this needed ? No, it's an leftover. I'll resend a patch fixed patch. - Martin Hostettler -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html