On Wed, Sep 14, 2011 at 03:28, Scott Jiang wrote: >>> +#ifdef CONFIG_VIDEO_ADV_DEBUG >> >> just use DEBUG ? >> > no, v4l2 use CONFIG_VIDEO_ADV_DEBUG ok, i was thinking this was something we added (since we have "ADVxxx" parts) >>> + v4l_info(client, "chip found @ 0x%02x (%s)\n", >>> + client->addr << 1, client->adapter->name); >> >> is that "<< 1" correct ? i dont think so ... > > every driver under media I see use this, so what's wrong? meh, they're all wrong imo then :p. they're shifting the address to accommodate datasheets that incorrectly specify the i2c "address" with the read/write as bit 0. but it's fine for this driver to do that if it's the standard that the rest of the v4l code has adopted. -mike -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
