On Tue, 2011-09-06 at 18:30 +0300, Antti Palosaari wrote: > On 09/06/2011 06:15 PM, Joe Perches wrote: > > On Tue, 2011-09-06 at 17:41 +0300, Antti Palosaari wrote: > >> So what is recommended way to ensure patch is correct currently? > >> a) before commit > > Use checkpatch. > >> b) after commit > > Make the output of the commit log look like a patch. > --format=email > But still that sounds annoying, GIT is our default tool for handling > patches and all the other tools like checkpatch.pl should honour that > without any tricks. Why you don't add some detection logic to > checkpatch.pl or even some new switch like --git. checkpatch is, as the name shows, for patches. I think using checkpatch on commit logs is not really useful. If you're using checkpatch on commit logs, format the commit log output appropriately or use --ignore=BAD_SIGN_OFF or add that --ignore= to a .checkpatch.conf if you really must. -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
