> -----Original Message----- > From: Laurent Pinchart [mailto:laurent.pinchart@xxxxxxxxxxxxxxxx] > Sent: Monday, September 05, 2011 6:20 PM > To: Mauro Carvalho Chehab > Cc: Hiremath, Vaibhav; Ravi, Deepthy; linux-media@xxxxxxxxxxxxxxx; linux- > kernel@xxxxxxxxxxxxxxx; linux-omap@xxxxxxxxxxxxxxx > Subject: Re: [PATCHv2] ISP:BUILD:FIX: Move media_entity_init() and > > Hi Mauro, > > On Sunday 04 September 2011 15:32:28 Mauro Carvalho Chehab wrote: > > Em 04-09-2011 06:01, Laurent Pinchart escreveu: > > > On Sunday 04 September 2011 00:21:38 Mauro Carvalho Chehab wrote: > > >> Em 24-08-2011 10:25, Laurent Pinchart escreveu: > > >>> On Wednesday 24 August 2011 14:19:01 Hiremath, Vaibhav wrote: > > >>>> On Wednesday, August 24, 2011 5:00 PM Laurent Pinchart wrote: > > >>>>> On Wednesday 24 August 2011 13:21:27 Ravi, Deepthy wrote: > > >>>>>> On Wed, Aug 24, 2011 at 4:47 PM, Laurent Pinchart wrote: > > >>>>>>> On Friday 19 August 2011 15:48:45 Deepthy Ravi wrote: > > >>>>>>>> From: Vaibhav Hiremath <hvaibhav@xxxxxx> > > >>>>>>>> > > >>>>>>>> Fix the build break caused when CONFIG_MEDIA_CONTROLLER > > >>>>>>>> option is disabled and if any sensor driver has to be used > > >>>>>>>> between MC and non MC framework compatible devices. > > >>>>>>>> > > >>>>>>>> For example,if tvp514x video decoder driver migrated to > > >>>>>>>> MC framework is being built without CONFIG_MEDIA_CONTROLLER > > >>>>>>>> option enabled, the following error messages will result. > > >>>>>>>> drivers/built-in.o: In function `tvp514x_remove': > > >>>>>>>> drivers/media/video/tvp514x.c:1285: undefined reference to > > >>>>>>>> `media_entity_cleanup' > > >>>>>>>> drivers/built-in.o: In function `tvp514x_probe': > > >>>>>>>> drivers/media/video/tvp514x.c:1237: undefined reference to > > >>>>>>>> `media_entity_init' <snip> > I don't mind splitting the config option. An alternative would be to > compile > media_entity_init() and media_entity_cleanup() based on > CONFIG_MEDIA_SUPPORT > instead of CONFIG_MEDIA_CONTROLLER, but that looks a bit hackish to me. > > > Also, I don't like the idea of increasing drivers complexity for the > > existing drivers that work properly without MC. All those core > conversions > > that were done in the last two years caused already too much instability > > to them. > > > > We should really avoid touching on them again for something that won't > be > > adding any new feature nor fixing any known bug. > > We don't have to convert them all in one go right now, we can implement > pad- > level operations support selectively when a subdev driver becomes used by > an > MC-enabled host/bridge driver. > [Hiremath, Vaibhav] I completely agree that we should not be duplicating the code just for sake of it. Isn't the wrapper approach seems feasible here? Thanks, Vaibhav > > > This will result in no modification to the userspace. > > -- > Regards, > > Laurent Pinchart -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
