On Mon, 2011-09-05 at 12:31 +0200, Laurent Pinchart wrote: > Hi Andy, > > On Friday 02 September 2011 15:09:28 Andy Shevchenko wrote: > > If configured with --with-libudev, the libmediactl is built with libudev > > support. It allows to get the device name in right way in the modern linux > > systems. > > Thanks for the patch. We're nearly there :-) I see. > This will break binary compatibility if an application creates a struct > media_device instances itself. On the other hand applications are not supposed > to do that. > > As the struct udev pointer is only used internally, what about passing it > around between functions explicitly instead ? That we will break the API in media_close(). Might be I am a blind, but I can't see the way how to do both 1) don't provide static global variable and 2) don't break the API/ABI. So, I'll send 5th version of the patchset with API breakage. Hope that what you could accept as a final version. -- Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> Intel Finland Oy -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
