On Thu, Sep 1, 2011 at 8:14 PM, Laurent Pinchart
<laurent.pinchart@xxxxxxxxxxxxxxxx> wrote:
> On Thursday 01 September 2011 19:24:54 Enrico wrote:
>> yavta will set UYVY (PIX_FMT), this will cause a call to
>> ispvideo.c:isp_video_pix_to_mbus(..), that will do this:
>>
>> for (i = 0; i < ARRAY_SIZE(formats); ++i) {
>> if (formats[i].pixelformat == pix->pixelformat)
>> break;
>> }
>>
>> that is it will stop at the first matching array item, and that's:
>>
>> { V4L2_MBUS_FMT_UYVY8_1X16, V4L2_MBUS_FMT_UYVY8_1X16,
>> V4L2_MBUS_FMT_UYVY8_1X16, 0,
>> V4L2_PIX_FMT_UYVY, 16, 16, },
>>
>>
>> but you wanted this:
>>
>> { V4L2_MBUS_FMT_UYVY8_2X8, V4L2_MBUS_FMT_UYVY8_2X8,
>> V4L2_MBUS_FMT_UYVY8_2X8, 0,
>> V4L2_PIX_FMT_UYVY, 8, 16, },
>>
>> so a better check could be to check for width too, but i don't know if
>> it's possibile to pass a width requirement or if it's already there in
>> some struct passed to the function.
>
> That's not really an issue, as the isp_video_pix_to_mbus() and
> isp_video_mbus_to_pix() calls in isp_video_set_format() are just used to fill
> the bytesperline and sizeimage fields. From a quick look at the code
> isp_video_check_format() should succeed as well.
>
> Have you run into any specific issue with isp_video_pix_to_mbus() when using
> V4L2_MBUS_FMT_UYVY8_2X8 ?
No, i assumed it was used to set the format on the pad too but this is
not the case, sorry for the noise.
Right now my problem is that i can't get the isp to generate
interrupts, i think there is some isp configuration error.
Enrico
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
