* Mauro Carvalho Chehab wrote: > Em 01-09-2011 02:19, Thierry Reding escreveu: > > * Mauro Carvalho Chehab wrote: > >> Em 04-08-2011 04:14, Thierry Reding escreveu: > >>> Instead of selecting the default interface setting when preparing > >>> isochronous transfers, select it on the first call to open() to make > >>> sure it is available earlier. > >> > >> Hmm... I fail to see what this is needed earlier. The ISOC endpont is used > >> only when the device is streaming. > >> > >> Did you get any bug related to it? If so, please describe it better. > > > > I'm not sure whether this really fixes a bug, but it seems a little wrong to > > me to selecting the interface so late in the process when in fact the device > > is already being configured before (video standard, audio mode, firmware > > upload, ...). > > Some applications may open the device just to change the controls. All other drivers > only set alternates/interfaces when the streaming is requested, as alternates/interfaces > are needed only there. Okay, I didn't know that it was only necessary for streaming. > > Thinking about it, this may actually be part of the fix for the "device hangs > > sometimes for inexplicable reasons" bug that this whole patch series seems to > > fix. > > It is unlikely, except if the firmware inside the chip is broken (unfortunately, > we have serious reasons to believe that the internal firmware on this chipset has > serious bugs). Indeed! =) > I prefer to not apply this patch, except if we have a good reason for that, > as otherwise this driver will behave different than the others. Okay, it's your call. Unfortunately I no longer have the hardware available to test if this is really related to the bug. I'll have to check again when I have the hardware. Thierry
Attachment:
pgpa_iZohS5pq.pgp
Description: PGP signature
