> > > >> Fix the build break caused when CONFIG_MEDIA_CONTROLLER > > > >> option is disabled and if any sensor driver has to be used > > > >> between MC and non MC framework compatible devices. > > > >> > > > >> For example,if tvp514x video decoder driver migrated to > > > >> MC framework is being built without CONFIG_MEDIA_CONTROLLER > > > >> option enabled, the following error messages will result. > > > >> drivers/built-in.o: In function `tvp514x_remove': > > > >> drivers/media/video/tvp514x.c:1285: undefined reference to > > > >> `media_entity_cleanup' > > > >> drivers/built-in.o: In function `tvp514x_probe': > > > >> drivers/media/video/tvp514x.c:1237: undefined reference to > > > >> `media_entity_init' > > > > > > > > If the tvp514x is migrated to the MC framework, its Kconfig option > > should > > > > depend on MEDIA_CONTROLLER. > > > > > > The same TVP514x driver is being used for both MC and non MC compatible > > > devices, for example OMAP3 and AM35x. So if it is made dependent on > > MEDIA > > > CONTROLLER, we cannot enable the driver for MC independent devices. > > > > Then you should use conditional compilation in the tvp514x driver itself. > > Or > [Hiremath, Vaibhav] No. I am not in favor of conditional compilation in driver code. > > > better, port the AM35x driver to the MC API. > > > [Hiremath, Vaibhav] > Why should we use MC if I have very simple device (like AM35x) which only supports single path? I can very well use simple V4L2 sub-dev based approach (master - slave), isn't it? Why should you break the API in unappropriated way? The patch is NACK, obviously. -- Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> Intel Finland Oy -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
