On Thu, 2011-08-18 at 13:53 +0300, Sakari Ailus wrote:
> On Thu, Aug 18, 2011 at 01:30:50PM +0300, Andy Shevchenko wrote:
> > On Thu, 2011-08-18 at 12:21 +0300, Sakari Ailus wrote:
> > > On Thu, Aug 18, 2011 at 11:53:03AM +0300, Andy Shevchenko wrote:
> > > > The ->power() could be absent or not used on some platforms. This patch makes
> > > > its presence optional.
> > >
> > > Hi Andy,
> > >
> > > Thanks for the patch!
> > >
> > > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> > > > Cc: Sakari Ailus <sakari.ailus@xxxxxx>
> > > > ---
> > > > drivers/media/video/adp1653.c | 3 +++
> > > > 1 files changed, 3 insertions(+), 0 deletions(-)
> > > >
> > > > diff --git a/drivers/media/video/adp1653.c b/drivers/media/video/adp1653.c
> > > > index 0fd9579..65f6f3f 100644
> > > > --- a/drivers/media/video/adp1653.c
> > > > +++ b/drivers/media/video/adp1653.c
> > > > @@ -309,6 +309,9 @@ __adp1653_set_power(struct adp1653_flash *flash, int on)
> > > > {
> > > > int ret;
> > > >
> > > > + if (flash->platform_data->power == NULL)
> > > > + return 0;
> > > > +
> > > > ret = flash->platform_data->power(&flash->subdev, on);
> > > > if (ret < 0)
> > > > return ret;
> >
> > > How about doing this in adp1653_set_power() instead of
> > > __adp1653_set_power()? At least I don't see any ill effects from this.
> > > There's no need to keep track of the power state (flash->power_count) if
> > > there isn't one. :-)
> > It was my first assumption. However, the __adp1653_set_power() is used
> > directly from suspend/resume methods.
>
> It is but it won't get called: power_count will be always zero when the
> power() callback doesn't exist.
Ah, now I got the full picture. Yes, if we leave adp1653_set_power()
immediately, then power_count stays 0.
I will send patch v2 soon.
--
Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
Intel Finland Oy
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
