Re: [PATCH] v4l2: Fix documentation of the codec device controls

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 01 Aug 2011 16:51:39 +0200 Kamil Debski wrote:

> Fixed missing ids of the codec controls description in the controls.xml file.
> 
> Signed-off-by: Kamil Debski <k.debski@xxxxxxxxxxx>
> Signed-off-by: Kyungmin Park <kyungmin.park@xxxxxxxxxxx>
> Reported-by: Randy Dunlap <rdunlap@xxxxxxxxxxxx>
> ---
> Hi,
> 
> This patch fixes the problem with codec controls documentation reported by Randy
> in the following email:
> http://comments.gmane.org/gmane.linux.drivers.video-input-infrastructure/36288
> 
> Thanks for reporting those errors.
> 
> Best wishes,
> Kamil

Hi,
This patch eliminates some (3) of the reported errors, but not all of them.

The fixed ones are:
Error: no ID for constraint linkend: v4l2-mpeg-video-h264-level.
Error: no ID for constraint linkend: v4l2-mpeg-video-h264-vui-sar-idc.
Error: no ID for constraint linkend: v4l2-mpeg-video-mpeg4-level.

but I still see these:
Error: no ID for constraint linkend: v4l2-mpeg-video-header-mode.
Error: no ID for constraint linkend: v4l2-mpeg-video-multi-slice-mode.
Error: no ID for constraint linkend: v4l2-mpeg-video-h264-entropy-mode.
Error: no ID for constraint linkend: v4l2-mpeg-video-h264-loop-filter-mode.
Error: no ID for constraint linkend: v4l2-mpeg-video-h264-profile.
Error: no ID for constraint linkend: v4l2-mpeg-video-mpeg4-profile.
Error: no ID for constraint linkend: v4l2-mpeg-mfc51-video-frame-skip-mode.
Error: no ID for constraint linkend: v4l2-mpeg-mfc51-video-force-frame-type.


> ---
>  Documentation/DocBook/media/v4l/controls.xml |   24 ++++++++++++------------
>  1 files changed, 12 insertions(+), 12 deletions(-)
> 
> diff --git a/Documentation/DocBook/media/v4l/controls.xml b/Documentation/DocBook/media/v4l/controls.xml
> index 8516401..09d6872 100644
> --- a/Documentation/DocBook/media/v4l/controls.xml
> +++ b/Documentation/DocBook/media/v4l/controls.xml
> @@ -1455,7 +1455,7 @@ Applicable to the H264 encoder.</entry>
>  	      </row>
>  
>  	      <row><entry></entry></row>
> -	      <row>
> +	      <row id="v4l2-mpeg-video-h264-vui-sar-idc">
>  		<entry spanname="id"><constant>V4L2_CID_MPEG_VIDEO_H264_VUI_SAR_IDC</constant>&nbsp;</entry>
>  		<entry>enum&nbsp;v4l2_mpeg_video_h264_vui_sar_idc</entry>
>  	      </row>
> @@ -1561,7 +1561,7 @@ Applicable to the H264 encoder.</entry>
>  	      </row>
>  
>  	      <row><entry></entry></row>
> -	      <row>
> +	      <row id="v4l2-mpeg-video-h264-level">
>  		<entry spanname="id"><constant>V4L2_CID_MPEG_VIDEO_H264_LEVEL</constant>&nbsp;</entry>
>  		<entry>enum&nbsp;v4l2_mpeg_video_h264_level</entry>
>  	      </row>
> @@ -1641,7 +1641,7 @@ Possible values are:</entry>
>  	      </row>
>  
>  	      <row><entry></entry></row>
> -	      <row>
> +	      <row id="v4l2-mpeg-video-mpeg4-level">
>  		<entry spanname="id"><constant>V4L2_CID_MPEG_VIDEO_MPEG4_LEVEL</constant>&nbsp;</entry>
>  		<entry>enum&nbsp;v4l2_mpeg_video_mpeg4_level</entry>
>  	      </row>
> @@ -1689,7 +1689,7 @@ Possible values are:</entry>
>  	      </row>
>  
>  	      <row><entry></entry></row>
> -	      <row>
> +	      <row id="v4l2-mpeg-h264-profile">
>  		<entry spanname="id"><constant>V4L2_CID_MPEG_VIDEO_H264_PROFILE</constant>&nbsp;</entry>
>  		<entry>enum&nbsp;v4l2_mpeg_h264_profile</entry>
>  	      </row>
> @@ -1774,7 +1774,7 @@ Possible values are:</entry>
>  	      </row>
>  
>  	      <row><entry></entry></row>
> -	      <row>
> +	      <row id="v4l2-mpeg-mpeg4-profile">
>  		<entry spanname="id"><constant>V4L2_CID_MPEG_VIDEO_MPEG4_PROFILE</constant>&nbsp;</entry>
>  		<entry>enum&nbsp;v4l2_mpeg_mpeg4_profile</entry>
>  	      </row>
> @@ -1820,7 +1820,7 @@ Applicable to the encoder.
>  	      </row>
>  
>  	      <row><entry></entry></row>
> -	      <row>
> +	      <row id="v4l2-mpeg-multi-slice-mode">
>  		<entry spanname="id"><constant>V4L2_CID_MPEG_VIDEO_MULTI_SLICE_MODE</constant>&nbsp;</entry>
>  		<entry>enum&nbsp;v4l2_mpeg_multi_slice_mode</entry>
>  	      </row>
> @@ -1868,7 +1868,7 @@ Applicable to the encoder.</entry>
>  	      </row>
>  
>  	      <row><entry></entry></row>
> -	      <row>
> +	      <row id="v4l2-mpeg-h264-loop-filter-mode">
>  		<entry spanname="id"><constant>V4L2_CID_MPEG_VIDEO_H264_LOOP_FILTER_MODE</constant>&nbsp;</entry>
>  		<entry>enum&nbsp;v4l2_mpeg_h264_loop_filter_mode</entry>
>  	      </row>
> @@ -1913,9 +1913,9 @@ Applicable to the H264 encoder.</entry>
>  	      </row>
>  
>  	      <row><entry></entry></row>
> -	      <row>
> +	      <row id="v4l2-mpeg-h264-entropy-mode">
>  		<entry spanname="id"><constant>V4L2_CID_MPEG_VIDEO_H264_ENTROPY_MODE</constant>&nbsp;</entry>
> -		<entry>enum&nbsp;v4l2_mpeg_h264_symbol_mode</entry>
> +		<entry>enum&nbsp;v4l2_mpeg_h264_entropy_mode</entry>
>  	      </row>
>  	      <row><entry spanname="descr">Entropy coding mode for H264 - CABAC/CAVALC.
>  Applicable to the H264 encoder.
> @@ -2140,7 +2140,7 @@ previous frames. Applicable to the H264 encoder.</entry>
>  	      </row>
>  
>  	      <row><entry></entry></row>
> -	      <row>
> +	      <row id="v4l2-mpeg-header-mode">
>  		<entry spanname="id"><constant>V4L2_CID_MPEG_VIDEO_HEADER_MODE</constant>&nbsp;</entry>
>  		<entry>enum&nbsp;v4l2_mpeg_header_mode</entry>
>  	      </row>
> @@ -2320,7 +2320,7 @@ Valid only when H.264 and macroblock level RC is enabled (<constant>V4L2_CID_MPE
>  Applicable to the H264 encoder.</entry>
>  	      </row>
>  	      <row><entry></entry></row>
> -	      <row>
> +	      <row id="v4l2-mpeg-mfc51-frame-skip-mode">
>  		<entry spanname="id"><constant>V4L2_CID_MPEG_MFC51_VIDEO_FRAME_SKIP_MODE</constant>&nbsp;</entry>
>  		<entry>enum&nbsp;v4l2_mpeg_mfc51_frame_skip_mode</entry>
>  	      </row>
> @@ -2361,7 +2361,7 @@ the stream will meet tight bandwidth contraints. Applicable to encoders.
>  </entry>
>  	      </row>
>  	      <row><entry></entry></row>
> -	      <row>
> +	      <row id="v4l2-mpeg-mfc51-force-frame-type">
>  		<entry spanname="id"><constant>V4L2_CID_MPEG_MFC51_VIDEO_FORCE_FRAME_TYPE</constant>&nbsp;</entry>
>  		<entry>enum&nbsp;v4l2_mpeg_mfc51_force_frame_type</entry>
>  	      </row>
> -- 


---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux