Chris W wrote:
On 20/07/11 23:18, Jarod Wilson wrote:
On Wed, Jul 20, 2011 at 08:05:43AM +1000, Chris W wrote:
On 20/07/11 02:12, Jarod Wilson wrote:
The imon devices have either 1 or 2 usb interfaces on them, each wired
up to its own urb callback. The interface 0 urb callback is wired up
before the imon context's rc_dev pointer is filled in, which is
necessary for imon 0xffdc device auto-detection to work properly, but
we need to make sure we don't actually run the callback routines until
we've entirely filled in the necessary bits for each given interface,
lest we wind up oopsing. Technically, any imon device could have hit
this, but the issue is exacerbated on the 0xffdc devices, which send a
constant stream of interrupts, even when they have no valid key data.
OK. The patch applies and everything continues to work. There is no
obvious difference in the dmesg output on module load, with my device
remaining unidentified. I don't know if that is indicative of anything.
Did you apply this patch on top of the earlier patch, or instead of it?
On top of it. I've reversed the patches and installed just the last
one with this result on loading the module:
input: iMON Panel, Knob and Mouse(15c2:ffdc) as
/devices/pci0000:00/0000:00:10.2/usb4/4-2/4-2:1.0/input/input8
imon 4-2:1.0: 0xffdc iMON VFD, iMON IR (id 0x24)
Registered IR keymap rc-imon-pad
input: iMON Remote (15c2:ffdc) as
/devices/pci0000:00/0000:00:10.2/usb4/4-2/4-2:1.0/rc/rc3/input9
rc3: iMON Remote (15c2:ffdc) as
/devices/pci0000:00/0000:00:10.2/usb4/4-2/4-2:1.0/rc/rc3
imon 4-2:1.0: iMON device (15c2:ffdc, intf0) on usb<4:3> initialized
usbcore: registered new interface driver imon
Much better.
Yeah, that looks sane now. We missed 3.0, but I'll try to flag this one
to go into the various stable trees when it gets merged for 3.1.
intf0 decoded packet: 00 00 00 00 00 00 24 01
intf0 decoded packet: 00 00 00 00 00 00 24 01
intf0 decoded packet: 00 00 00 00 00 00 24 01
One other amusing tidbit: you get continuous spew like the above, because
to date, I thought all the ffdc devices had "nothing to report" spew that
started with 0xffffff, which we filter out. Sigh. I hate imon hardware...
I am beginning to understand why. That output was only printed with the
"debug=1" option and is not printed with the patched module.
Yup. The additional filtering was added because my own ffdc imon devices
were so noisy, it was next to impossible to see what was going on when
trying to debug anything.
--
Jarod Wilson
jarod@xxxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
