Hi, Andy! On Mon, Jul 25, 2011 at 05:16:41PM +0300, Andy Shevchenko wrote: > The driver requires platform_data to be present. That's why we need to check > and fail in case of the absence of necessary data. > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> > Cc: Mauro Carvalho Chehab <mchehab@xxxxxxxxxxxxx> > Cc: Sakari Ailus <sakari.ailus@xxxxxx> > --- > drivers/media/video/adp1653.c | 4 ++++ > 1 files changed, 4 insertions(+), 0 deletions(-) Thanks for the patch. I'll add this to my next pull req. > > diff --git a/drivers/media/video/adp1653.c b/drivers/media/video/adp1653.c > index be7befd..8ad89ff 100644 > --- a/drivers/media/video/adp1653.c > +++ b/drivers/media/video/adp1653.c > @@ -413,6 +413,10 @@ static int adp1653_probe(struct i2c_client *client, > struct adp1653_flash *flash; > int ret; > > + /* we couldn't work without platform data */ > + if (client->dev.platform_data == NULL) > + return -ENODEV; > + > flash = kzalloc(sizeof(*flash), GFP_KERNEL); > if (flash == NULL) > return -ENOMEM; > -- > 1.7.5.4 > -- Sakari Ailus sakari.ailus@xxxxxx -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
