Hadli, Manjunath wrote: > Sakari, Thank you for your comments. I agree with them and fix. > Please comment on the rest of the patches as well. > -Manju> Hi Manju, I'll attempt to find more time for this. [clip] >>> +/* CFG1 Masks and shifts */ >>> +#define ONESHOT_SHIFT (0) >>> +#define DECIM_SHIFT (1) >>> +#define INPSRC_SHIFT (2) >>> +#define CLKDIV_SHIFT (4) >>> +#define AVGFILT_SHIFT (7) >>> +#define PACK8IN_SHIFT (8) >>> +#define IALAW_SHIFT (9) >>> +#define CLKSEL_SHIFT (10) >>> +#define DATASFT_SHIFT (11) >>> +#define INPSRC1_SHIFT (14) >> >> IPIPEIF prefix. Are these related to a particular register or a set of registers? > One register. Will need to add the IPIPEIF prefix. Assuming CFG1 is the name of the register, what about IPIPEIF_CFG1_...? >>> +/* DPC2 */ >>> +#define IPIPEIF_DPC2_EN_SHIFT (12) >>> +#define IPIPEIF_DPC2_THR_MASK (0xFFF) >>> +#define IPIPEIF_DF_GAIN_EN_SHIFT (10) >>> +#define IPIPEIF_DF_GAIN_MASK (0x3FF) >>> +#define IPIPEIF_DF_GAIN_THR_MASK (0xFFF) Also all of these should have DPC2 prefix before DPC2 if they're all for the same register. Regards, -- Sakari Ailus sakari.ailus@xxxxxx -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
