Hi Vaibhav, On Thursday 14 July 2011 10:05:41 Hiremath, Vaibhav wrote: > On Thursday, July 14, 2011 3:50 AM Laurent Pinchart wrote: > > On Wednesday 13 July 2011 20:22:27 Joel A Fernandes wrote: > > > * Adds support for mt9v113 sensor by borrowing heavily from PSP 2.6.37 > > > kernel patches * Adapted to changes in v4l2 framework and ISP driver > > > > Here are a few comments about the code. I've left political issues aside > > on purpose. > > As always thanks for your comments. > > Laurent, > But here the question is nowhere related to politics. I do not care about > authorship at all; this is completely engineering argument/discussion I have > with this patch. > > I have been working with community since long time now, so I was not in > favor of submitting this patch with so many known issues (from both feature > and cleanliness). If you look at all the comments you provided, most of them > should have been already part of the patch series. I totally agree with you on this. That's why I haven't done any in-depth review of the patch, but just quickly looked through it. > I wanted them to fix before submitting it to the linux-media, it doesn't > matter whether it's RFC. > > Another point FYI, the sensor driver has been written during 2.6.37 > timeframe, where media-controller was still under flux. Since I wanted to > make our production release with MC framework, I pulled in patches from your > private branch and started developing from there, so definitely there will > be various issues with the driver Vs the current mainline status. > > > If I would have been aware that, somebody is willing to push my patches, I > could have helped him or worked with him (that will ease my bandwidth). > > I just made my stand clear here, and I think we should park this discussion > here now. We talked enough on this, and I believe we all understand this. -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
