> -----Original Message----- > From: linux-media-owner@xxxxxxxxxxxxxxx [mailto:linux-media- > owner@xxxxxxxxxxxxxxx] On Behalf Of Joel A Fernandes > Sent: Thursday, July 14, 2011 6:49 AM > To: beagleboard@xxxxxxxxxxxxxxxx > Cc: Kridner, Jason; Javier Martin; laurent.pinchart@xxxxxxxxxxxxxxxx; > linux-media@xxxxxxxxxxxxxxx; Kooi, Koen; Prakash, Punya; Maupin, Chase; > Kipisz, Steven; Aguirre, Sergio > Subject: Re: [beagleboard] [RFC v1] mt9v113: VGA camera sensor driver and > support for BeagleBoard > > Hi Vaibhav, > > Thanks for your email. > > On Wed, Jul 13, 2011 at 2:55 PM, Hiremath, Vaibhav <hvaibhav@xxxxxx> > wrote: > > > >> -----Original Message----- > >> From: beagleboard@xxxxxxxxxxxxxxxx > [mailto:beagleboard@xxxxxxxxxxxxxxxx] > >> On Behalf Of Joel A Fernandes > >> Sent: Wednesday, July 13, 2011 11:52 PM > >> To: beagleboard@xxxxxxxxxxxxxxxx > >> Cc: Joel A Fernandes; Kridner, Jason; Javier Martin; > >> laurent.pinchart@xxxxxxxxxxxxxxxx; linux-media@xxxxxxxxxxxxxxx; Kooi, > >> Koen; Prakash, Punya; Maupin, Chase; Kipisz, Steven; Aguirre, Sergio > >> Subject: [beagleboard] [RFC v1] mt9v113: VGA camera sensor driver and > >> support for BeagleBoard > >> > >> * Adds support for mt9v113 sensor by borrowing heavily from PSP 2.6.37 > >> kernel patches > >> * Adapted to changes in v4l2 framework and ISP driver > >> > >> Signed-off-by: Joel A Fernandes <agnel.joel@xxxxxxxxx> > >> --- > >> This patch will apply against the 2.6.39 kernel built from the OE- > >> development tree (Which is essentially > >> the v2.6.39 from the main tree with OE patches for BeagleBoard support > and > >> a few other features) > >> > >> If you have the Leapord imaging camera board with this particular > sensor, > >> I would apprecite it if anyone could > >> try this patch out and provide any feedback/test results. > >> > >> To get the complete tree which works on a BeagleBoard-xM with all the > OE > >> patches and this patch, > >> you can clone: https://github.com/joelagnel/linux-omap-2.6/tree/oedev- > >> 2.6.39-mt9v113 > >> > >> It will compile and work on a BeagleBoard-xM with the defconfig at: > >> > http://cgit.openembedded.org/cgit.cgi/openembedded/tree/recipes/linux/linu > >> x-omap-2.6.39/beagleboard/defconfig > >> > >> Also you will need to apply my media-ctl patch (or clone the tree) to > >> setup the formats: > >> https://github.com/joelagnel/media- > >> ctl/commit/cdf24d1249ac1ff3cd6f70ad80c3b76ac28ba0d5 > >> > >> Binaries for quick testing on a BeagleBoard-xM: > >> U-boot: http://utdallas.edu/~joel.fernandes/u-boot.bin > >> U-boot: http://utdallas.edu/~joel.fernandes/MLO > >> uEnv.txt: http://utdallas.edu/~joel.fernandes/uEnv.txt > >> media-ctl: http://utdallas.edu/~joel.fernandes/media-ctl > >> kernel: http://utdallas.edu/~joel.fernandes/uImage > >> > >> media-ctl/yavta commands you could use to get it to show a picture can > be > >> found at: > >> http://utdallas.edu/~joel.fernandes/stream.sh > >> > >> Note: > >> The BeagleBoard camera board file in this patch replaces the old one, > so > >> this will take away support for the 5M > >> sensor (mt9p031), I hope this can be forgiven considering this is an > >> RFC :). I am working on a common board file > >> that will work for both sensors. > >> > > [Hiremath, Vaibhav] Joel, > > > > I am bit surprised by this patch submission, first of all, the patch has > been submitted without my knowledge. And I was not aware that you are > targeting linux-media for this code-snippet. > > > > This code needs lot of cleanup and changes to get to the level where we > can submit it to the linux-media, and I think I clearly mentioned about > known issues with this patch/driver in the commit itself. Please refer to > the below commit - > > > > http://arago-project.org/git/projects/?p=linux- > omap3.git;a=commitdiff;h=c6174e0658b9aaa8f7a3ec9fe562619084d34f59 > > > > I agree that we had some internal discussion on this and I was under > assumption that this effort was only towards beagle openembedded and not > for linux-media. > > > [Joel] > > I'm sorry, actually the intent of the RFC was to get immediate VGA > camera support to Beagle users and some testing with our kernel. [Hiremath, Vaibhav] If you had posted this to beagle list alone, I wouldn't had any issues and that's what I was expecting when we discussed internally. For me beagle list is custom list and for beagle developers on their kernel version (like 2.6.39 here). > The > other intention was to help your team with the differences in what has > changed across the kernels as a reference so that you reuse some of > the work. Certainly I was not going to claim authorship or make the > final submission. > > About Signed-off-by lines (if that's what you refer to about > authorship), I intentionally didn't include it in my temporary git > tree as I wanted to make sure if I could use it without permission. My > intention was to rebase and include the relevant SOB lines after I got > clarification on this. Could you suggest a general rule about SOB > lines and whether these can be used without permission when you > reuse/adapt a patch? > [Hiremath, Vaibhav] Joel, I have issues with the technical contents of the patch itself, so if you would have submitted patch with my knowledge, I would have helped you atleast in review before submitting (that would have saved us from this noise). Thanks, Vaibhav > I hoped that the words "borrowed from PSP" in the commit summary, the > relevant links to the commits in your tree in the commit summaries and > the retaining of copyright information in the code made it clear that > I was not the original author. > > I understand that it is a bit frustrating to see someone take your > code when its not yet complete, anyway I hope my commits help in some > way. Atleast there might be a few people who test your code on the > Beagle and give your team some valuable feedback. > > Thanks, > Joel > -- > To unsubscribe from this list: send the line "unsubscribe linux-media" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
