Hi,
On Monday 11 July 2011 11:48:11 Ming Lei wrote:
> From 989d894a2af7ceadf2574f455d9e68779f4ae674 Mon Sep 17 00:00:00 2001
> From: Ming Lei <ming.lei@xxxxxxxxxxxxx>
> Date: Mon, 11 Jul 2011 17:04:31 +0800
> Subject: [PATCH] uvcvideo: add fix suspend/resume quirk for Microdia camera
>
> We found this type(0c45:6437) of Microdia camera does not
> work(no stream packets sent out from camera any longer) after
> resume from sleep, but unbind/bind driver will work again.
>
> So introduce the quirk of UVC_QUIRK_FIX_SUSPEND_RESUME to
> fix the problem for this type of Microdia camera.
Thank you for the patch.
[snip]
> + /* For some buggy cameras, they will not work after wakeup, so
> + * do unbind in .usb_suspend and do rebind in .usb_resume to
> + * make it work again.
> + * */
> + if (dev->quirks & UVC_QUIRK_FIX_SUSPEND_RESUME) {
> + uvc_driver.driver.suspend = NULL;
> + uvc_driver.driver.resume = NULL;
> + } else {
> + uvc_driver.driver.suspend = uvc_suspend;
> + uvc_driver.driver.resume = uvc_resume;
> + }
> +
That's unfortunately not acceptable as-is. If two cameras are connected to the
system, and only one of them doesn't support suspend/resume, the other will be
affected by your patch.
Have you tried to investigate why suspend/resume fails for the above-mentioned
camera, instead of working around the problem ?
--
Regards,
Laurent Pinchart
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
