Hi, On 06/28/2011 07:32 PM, Mauro Carvalho Chehab wrote:
This is an automatic generated email to let you know that the following patch were queued at the http://git.linuxtv.org/xawtv3.git tree: Subject: xawtv: reenable its usage with webcam's Author: Mauro Carvalho Chehab<mchehab@xxxxxxxxxx> Date: Tue Jun 28 14:22:55 2011 -0300 git changeset c28978f3693bc0f40607d0b3e589774b9452608d was requiring that tuner would be available, in order to allow it to run. Relax the restriction, in order to allow using xawtv to test webcams, restoring the previous behavior. Signed-off-by: Mauro Carvalho Chehab<mchehab@xxxxxxxxxx> libng/grab-ng.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) --- http://git.linuxtv.org/xawtv3.git?a=commitdiff;h=2238f79d9fb2801a3acd114242b437686fa2f0c8 diff --git a/libng/grab-ng.c b/libng/grab-ng.c index f5203cc..94f31e8 100644 --- a/libng/grab-ng.c +++ b/libng/grab-ng.c @@ -563,9 +563,9 @@ static void *ng_vid_open_auto(struct ng_vid_driver *drv, char *devpath) continue; } - /* Check caps return this device if it can capture and has a tuner */ + /* Check caps return this device if it can capture */ caps = drv->capabilities(handle); - if ((caps& CAN_CAPTURE)&& (caps& CAN_TUNE)) + if (caps& CAN_CAPTURE) break; drv->close(handle);
Hmm, this changes the behavior from what I intended, the idea was to select the first *tv-card*, without checking for a tuner, there is little value in the auto device feature. Granted it will still skip v4l2 output only devices but those are very rare. Note that only the xawtv binary is using a device value of "auto" by default, the webcam tool still defaults to /dev/video0 Given that xawtv is specifically meant for tv-cards (unlike the webcam tool) failing if it cannot find a tv-card and no device is explicitly specified seems reasonable. Alternatively we could make the desired caps a param too ng_vid_open_auto and first try with (CAN_CAPTURE | CAN_TUNE) and then retry with only CAN_CAPTURE. The above patch definitely is not what I had in mind. My system has a bt878 tv card, and a varying number of webcams connected, thus constantly changing the /dev/video# for the tv-card. The intent of my "auto" device patches was to make xawtv automatically pick the tvcard. Regards, Hans p.s. I intented to mail you about my get_media_devices fixes as well as my auto device patches, and suggest that we do a new release soon. But first we need to sort out the auto device thingie. If you could fix it to first look for cards with a tuner and if none is available fall back to just looking for capture capable cards that would be great, I'm a bit busy atm I'm afraid. -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
