On Sunday 26 June 2011 20:51:37 Mauro Carvalho Chehab wrote: > > > > I mean what do you return to vfs_ioctl from v4l? The conversions must > > have been long before we introduced compat_ioctl and ENOIOCTLCMD. > > > > As far as I can tell, video_ioctl2 has always converted ENOIOCTLCMD into > > EINVAL, so changing the vfs functions would not have any effect. > > Yes. This discussion was originated by a RFC patch proposing to change > video_ioctl2 to return -ENOIOCTLCMD instead of -EINVAL. Ok, I see. So returning -ENOIOCTLCMD is not an option IMHO, but if you are confident that it doesn't break anything, returning -ENOTTY would be possible and doesn't require any core changes. Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
