Hello, On Tuesday, June 21, 2011 10:26 PM Mauro Carvalho Chehab wrote: > Em 20-06-2011 16:14, Jonathan Corbet escreveu: > > The core driver can now operate in either vmalloc or dma-contig modes; > > obviously the latter is preferable when it is supported. Default is > > currently vmalloc on all platforms; load the module with buffer_mode=1 > for contiguous DMA mode. > > Patch looks correct. > > A side note for vb2 maintainers: > > IMO, vb2 core should take the responsibility to allow to switch between DMA > scatter/gather and continuous (and, eventually, vmalloc), where the bridge > driver support more than one option. > Otherwise, we'll end by having codes similar to that on all drivers that > can be used on different architectures. Could you elaborate a bit more on this issue? Depending on driver needs, on just sets queue->mem_ops to vb2_vmalloc_memops, vb2_dma-contig_memops or vb2_dma-sg_memops. There is no dependencies between the core and memory allocators/handlers. Best regards -- Marek Szyprowski Samsung Poland R&D Center -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
