On Monday, June 20, 2011 15:05:47 Laurent Pinchart wrote: > Hi Hans, > > Thanks for the patch. > > On Tuesday 07 June 2011 17:05:13 Hans Verkuil wrote: > > From: Hans Verkuil <hans.verkuil@xxxxxxxxx> > > > > It is a bit tricky to handle autogain/gain type scenerios correctly. Such > > controls need to be clustered and the V4L2_CTRL_FLAG_UPDATE should be set > > on the autofoo controls. In addition, the manual controls should be marked > > inactive when the automatic mode is on, and active when the manual mode is > > on. This also requires specialized volatile handling. > > > > The chances of drivers doing all these things correctly are pretty remote. > > So a new v4l2_ctrl_auto_cluster function was added that takes care of these > > issues. > > Sorry for being a killjoy, but how is this supposed to handle the auto- > exposure control ? Auto-exposure can be in complete auto mode, where both > exposure time and aperture are controlled automatically, in exposure- or > aperture-priority mode, where only one the exposure time and aperture is > controlled automatically, or in manual mode. That you will have to implement yourself. This may need some additional support from the framework. v4l2_ctrl_auto_cluster() is meant to cater to most, but not necessarily all, use cases. This particular case clearly falls out of the scope of that function. Hmm, perhaps it should be extended with an optional callback function. That would be the most general approach. But let's deal with that when we get there. Regards, Hans -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
