2011/6/17 Mauro Carvalho Chehab <mchehab@xxxxxxxxxxxxx>:
> Em 15-06-2011 23:30, Kassey Lee escreveu:
>> 2011/6/14 Jonathan Corbet <corbet@xxxxxxx>:
>>> On Tue, 14 Jun 2011 10:58:47 +0800
>>> Kassey Lee <kassey1216@xxxxxxxxx> wrote:
>>>>> + /*
>>>>> + * Try to find the sensor.
>>>>> + */
>>>>> + cam->sensor_addr = ov7670_info.addr;
>>>>> + cam->sensor = v4l2_i2c_new_subdev_board(&cam->v4l2_dev,
>>>>> + &cam->i2c_adapter, &ov7670_info, NULL);
>>>> I do not thinks so.
>>>
>>> I don't understand what this comment is meant to mean...?
>> this should be move out to arch/arm/mach-xxx/board.c
>
> Please drop the parts that you're not commenting. It is very hard to find a one-line
> comment in the middle of a long patch, especially since you don't even add blank
> lines before/after it.
>
sorry for the confusion.
this is the same idea that we want to separate the ccic driver and sensor info.
here is how we do this:
on arch/arm/mach-mmp/ttc_dkb.c
static struct i2c_board_info dkb_i2c_camera[] = {
{
I2C_BOARD_INFO("ov5642", 0x3c),
},
};
i2c_register_board_info(0, &dkb_i2c_camera, 1);
> With respect to your comment, it doesn't makes much sense,as cafe_ccic
> runs on OLPC 1 hardware (at least the version I have here) is x86-based.
>
that is fine, sorry, i always thought it was ARM platform.
> So, I'm not seeing any reason why not apply patch 2/8.
>
> Applying on my tree.
>
> Mauro.
>
>
--
Best regards
Kassey
Application Processor Systems Engineering, Marvell Technology Group Ltd.
Shanghai, China.
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
