On Thu, Jun 16, 2011 at 10:35:49AM -0400, Alan Stern wrote:
> On Thu, 16 Jun 2011, Laurent Pinchart wrote:
> > On Thursday 16 June 2011 04:59:57 Sarah Sharp wrote:
> > > On Wed, Jun 15, 2011 at 06:39:57PM -0700, Sarah Sharp wrote:
> > > > I've grepped through drivers/media/video, and it seems like none of the
> > > > drivers handle the -EXDEV status. What should the xHCI driver be
> > > > setting the URB's status and frame status to when the xHCI host
> > > > controller skips over transfers? -EREMOTEIO?
> > > >
> > > > Or does it need to set the URB's status to zero, but only set the
> > > > individual frame status to -EXDEV?
> > >
> > > Ok, looking at both EHCI and UHCI, they seem to set the urb->status to
> > > zero, regardless of what they set the frame descriptor field to.
> > >
> > > Alan, does that seem correct?
>
> The description of the behavior of ehci-hcd and uhci-hcd is correct.
> ohci-hcd behaves the same way too. And they all agree with the
> behavior described in the kerneldoc for struct urb in
> include/linux/usb.h.
Ah, you mean this bit?
* @status: This is read in non-iso completion functions to get the
* status of the particular request. ISO requests only use it
* to tell whether the URB was unlinked; detailed status for
* each frame is in the fields of the iso_frame-desc.
> > According to Documentation/usb/error-codes.txt, host controller drivers should
> > set the status to -EXDEV. However, no device drivers seem to handle that,
> > probably because the EHCI/UHCI drivers don't use that error code.
> >
> > Drivers are clearly out of sync with the documentation, so we should fix one
> > of them.
>
> Under the circumstances, the documentation file should be changed.
> Sarah, can you do that along with the change to xhci-hcd?
Sure. It feels like there should be a note about which values
isochronous URBs might have in the urb->status field. The USB core is
the only one that would be setting those, so which values would it set?
uvcvideo tests for these error codes:
case -ENOENT: /* usb_kill_urb() called. */
case -ECONNRESET: /* usb_unlink_urb() called. */
case -ESHUTDOWN: /* The endpoint is being disabled. */
case -EPROTO: /* Device is disconnected (reported by some
* host controller). */
Are there any others.
Sarah Sharp
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
