On Sat, Jun 11, 2011 at 11:05 AM, Hans Verkuil <hverkuil@xxxxxxxxx> wrote: > Second version of this patch series. > > It's the same as RFCv1, except that I dropped the g_frequency and > g_tuner/s_tuner patches (patch 3, 6 and 7 in the original patch series) > because I need to think more on those, and I added a new fix for tuner_resume > which was broken as well. Hi Hans, I appreciate your taking the time to refactor this code (no doubt it really needed it). All that I ask is that you please actually *try* the resulting patches with VLC and a tuner that supports standby in order to ensure that it didn't cause any regressions. This stuff was brittle to begin with, and there are lots of opportunities for obscure/unexpected effects resulting from what appear to be sane changes. The last series of patches that went in were in response to this stuff being very broken, and I would hate to see a regression in existing applications after we finally got it working. Thanks, Devin -- Devin J. Heitmueller - Kernel Labs http://www.kernellabs.com -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
