On Fri, 10 Jun 2011, Kassey Lee wrote: > hi, Guennadi: > > in drivers/media/video/soc_camera.c > static int soc_camera_open(struct file *file) > > it will call soc_camera_set_fmt to configure the sensor and host controller. > for sensor, this means it will trigger download setting, this may take quite > time through i2c or SPI. > I complain about this, because after we open, request, s_param, S_FMT, > DQBUF, > in S_FMT, we will download the setting again. > > how do you think ? If it's a concern for you, you might consider moving most of your sensor set up from .s_(mbus_)fmt() to .s_stream(). Would that solve your problem? Thanks Guennadi > > > /* > * Try to configure with default parameters. Notice: this is > the > * very first open, so, we cannot race against other calls, > * apart from someone else calling open() simultaneously, but > * .video_lock is protecting us against it. > */ > ret = soc_camera_set_fmt(icd, &f); > if (ret < 0) > goto esfmt; > > -- > Best regards > Kassey > Application Processor Systems Engineering, Marvell Technology Group Ltd. > Shanghai, China. > --- Guennadi Liakhovetski, Ph.D. Freelance Open-Source Software Developer http://www.open-technology.de/ -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
