On Mon, Jun 6, 2011 at 10:00 PM, Devin Heitmueller <dheitmueller@xxxxxxxxxxxxxx> wrote: > On Mon, Jun 6, 2011 at 3:22 PM, Peter Moon <pomoon@xxxxxxxxx> wrote: >> This patch adds support for the " Hauppauge WinTV USB2-FM" Analog Stick. >> >> Signed-off-by: Peter Moon <pomoon@xxxxxxxxx> > > My only comment is that the func_mode in cx231xx_dif_set_standard() > should be 0x01, not 0x03. Change that, resubmit the patch after > testing, and I will put my Reviewed-By on it. I will make the change you suggest and retest. > Also, there is actually another USB ID which is the exact same product > (but targeted at NTSC by default). I'll have to lookup the ID though. According to the Windows driver inf file that I have, the USB ID of the NTSC version is 2040:b111. I can add the USB device definition for the NTSC targeted device as well. Peter Moon -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html