Re: [PATCH] V4L: pxa_camera: remove redundant calculations

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 6 Jun 2011, Robert Jarzmik wrote:

> On 06/06/2011 07:02 PM, Guennadi Liakhovetski wrote:
> > soc_camera core now performs the standard .bytesperline and .sizeimage
> > calculations internally, no need to duplicate in drivers.
> Haven't I noticed that this patch is twofold :
>  - the calculation duplication
>  - the suspend/resume change from old suspend/resume to new v4l2_subdev power
> function
> 
> Shouldn't this patch have either the commit message amended, or even better be
> split into 2 distinct patches ?

Oops, yes, indeed, will split, thanks for catching!

> Apart from that, the patch looks ok to me.

Guennadi
---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux