Re: [PATCH] V4L: tw9910: remove bogus ENUMINPUT implementation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Morimoto-san, sorry, that was a wrong address of yours again in the 
original mail. With the correct request also comes a request: would it be 
difficult for you to give this patch a try? If you don't happen to have a 
set up ready at hand, no problem, I'll dig out some video signal source 
myself and test.

Thanks
Guennadi

On Mon, 6 Jun 2011, Guennadi Liakhovetski wrote:

> tw9910 is a TV decoder, it doesn't have a tuner. Besides, the
> .enum_input soc-camera operation is optional and normally not needed.
> 
> Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@xxxxxx>
> ---
>  drivers/media/video/tw9910.c |   11 -----------
>  1 files changed, 0 insertions(+), 11 deletions(-)
> 
> diff --git a/drivers/media/video/tw9910.c b/drivers/media/video/tw9910.c
> index 0347bbe..a722f66 100644
> --- a/drivers/media/video/tw9910.c
> +++ b/drivers/media/video/tw9910.c
> @@ -552,16 +552,6 @@ static int tw9910_s_std(struct v4l2_subdev *sd, v4l2_std_id norm)
>  	return ret;
>  }
>  
> -static int tw9910_enum_input(struct soc_camera_device *icd,
> -			     struct v4l2_input *inp)
> -{
> -	inp->type = V4L2_INPUT_TYPE_TUNER;
> -	inp->std  = V4L2_STD_UNKNOWN;
> -	strcpy(inp->name, "Video");
> -
> -	return 0;
> -}
> -
>  static int tw9910_g_chip_ident(struct v4l2_subdev *sd,
>  			       struct v4l2_dbg_chip_ident *id)
>  {
> @@ -891,7 +881,6 @@ static int tw9910_video_probe(struct soc_camera_device *icd,
>  static struct soc_camera_ops tw9910_ops = {
>  	.set_bus_param		= tw9910_set_bus_param,
>  	.query_bus_param	= tw9910_query_bus_param,
> -	.enum_input		= tw9910_enum_input,
>  };
>  
>  static struct v4l2_subdev_core_ops tw9910_subdev_core_ops = {
> -- 
> 1.7.2.5
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux