Re: [PATCH v2 3/4] m5mols: remove union in the m5mols_get_version(), and VERSION_SIZE

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Jun 05, 2011 at 03:03:47PM +0300, Sakari Ailus wrote:
[clip]
> > -	/* store version information swapped for being readable */
> > -	info->ver	= version.ver;
> >  	info->ver.fw	= be16_to_cpu(info->ver.fw);
> >  	info->ver.hw	= be16_to_cpu(info->ver.hw);
> >  	info->ver.param	= be16_to_cpu(info->ver.param);
> 
> As you have a local variable ver pointing to info->ver, you should also use
> it here.

With this change,

Acked-by: Sakari Ailus <sakari.ailus@xxxxxx>

-- 
Sakari Ailus
sakari dot ailus at iki dot fi
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux