[bug-report] unconditionally calling cxd2820r_get_tuner_i2c_adapter() from em28xx-dvb.c creates a hard module dependency

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello,

I noticed this warning 

    WARNING: "cxd2820r_get_tuner_i2c_adapter" [/usr/local/src/git/linux-2.6/drivers/media/video/em28xx/em28xx-dvb.ko] undefined!

while building the driver in 2.6.32 with backported 290e support.  This
warning does not appear with 3.0.0-rc1, but the call still does cause a
hard dependency on cxd2820r even if you build with CONFIG_MEDIA_ATTACH=y:

bjorn@canardo:/usr/local/src/git/linux-2.6$ modinfo drivers/media/video/em28xx/em28xx-dvb.ko
filename:       drivers/media/video/em28xx/em28xx-dvb.ko
license:        GPL
author:         Mauro Carvalho Chehab <mchehab@xxxxxxxxxxxxx>
description:    driver for em28xx based DVB cards
depends:        cxd2820r,dvb-core,em28xx,usbcore
vermagic:       3.0.0-rc1+ SMP mod_unload modversions 
parm:           debug:enable debug messages [dvb] (int)
parm:           adapter_nr:DVB adapter numbers (array of short)

I assume this is unwanted.  As you can see, cxd2820r is the only
frontend dependency....

Don't know the proper fix.  My naÃve quick-fix was just to move struct
cxd2820r_priv into cxd2820r.h and making the function static inlined.
However, I do see that you may not want the struct in cxd2820r.h.  But I
trust that you have a brilliant solution to the problem :-)

Thanks for your great work on the cxd2820r driver and nanostick T2 290e
support!



BjÃrn
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux