Re: [PATCH v4 0/3] TV driver for Samsung S5P platform (media part)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



JiUn Yu wrote:
5. Mixer & Video Processor driver. It is called 's5p-mixer' because of
historical reasons. It was decided combine VP and MXR drivers into one because
of shared interrupt and very similar interface via V4L2 nodes. The driver is a
realization of many-to-many relation between multiple input layers and multiple
outputs. All shared resources are kept in struct mxr_device. It provides
utilities for management and synchronization of access to resources and
reference counting. The outputs are obtained from HDMI/SDO private data.  One
layer is a single video node. Simple inheritance is applied because there only
little difference between layer's types. Every layer type implements set of
ops.  There are different ops for Mixer layers and other for VP layer.

I agreed with subdev of hdmi, hdmiphy, sdo and videoDAC. It is very flexible in case of adding new interface or removing current interface.
But 's5p-mixer' driver is not flexible. So, If new scaler is added instead of VP or mixer is someting changed,
I think current architecture of tvout driver can't support.
How about separating vp and mixer driver?
Hi Yu,
The designed architecture TV driver was not prepared for removal of VP, or MIxer input nodes. I decided only to allow flexible outputs because I knew 2 boards with different output configuration (Goni - only SDO, Universal - HDMI and SDO). I need more information about VP substitute before changing design of the whole driver. Some of extensions could be applied by adding extra layer type to existing layer_vp and layer_grp ones.

Best regards
Tomasz Stanislawski
NëêïríyéìbìÐívï^ï)é{.nï+ëì{ìïbj)ïïw*jgÐïíìëì/êïzëëï2ëìéï&ï)åìëïïììïhïïj:+vëëïæ

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux