Re: [PATCH] [media] gspca/kinect: wrap gspca_debug with GSPCA_DEBUG

[Jean-Francois Moine <moinejf@xxxxxxx>]

On Wed, 25 May 2011 17:34:32 -0400
Jarod Wilson <jarod@xxxxxxxxxx> wrote:

> diff --git a/drivers/media/video/gspca/kinect.c b/drivers/media/video/gspca/kinect.c
> index 66671a4..26fc206 100644
> --- a/drivers/media/video/gspca/kinect.c
> +++ b/drivers/media/video/gspca/kinect.c
> @@ -34,7 +34,7 @@ MODULE_AUTHOR("Antonio Ospite <ospite@xxxxxxxxxxxxxxxxx>");
>  MODULE_DESCRIPTION("GSPCA/Kinect Sensor Device USB Camera Driver");
>  MODULE_LICENSE("GPL");
>  
> -#ifdef DEBUG
> +#ifdef GSPCA_DEBUG
>  int gspca_debug = D_ERR | D_PROBE | D_CONF | D_STREAM | D_FRAM | D_PACK |
>  	D_USBI | D_USBO | D_V4L2;
>  #endif

Hi Jarod,

Sorry, it is not the right fix. In fact, the variable gspca_debug must
not be defined in gspca subdrivers:

--- a/drivers/media/video/gspca/kinect.c
+++ b/drivers/media/video/gspca/kinect.c
@@ -34,11 +34,6 @@
 MODULE_DESCRIPTION("GSPCA/Kinect Sensor Device USB Camera Driver");
 MODULE_LICENSE("GPL");
 
-#ifdef DEBUG
-int gspca_debug = D_ERR | D_PROBE | D_CONF | D_STREAM | D_FRAM | D_PACK |
-	D_USBI | D_USBO | D_V4L2;
-#endif
-
 struct pkt_hdr {
 	uint8_t magic[2];
 	uint8_t pad;

-- 
Ken ar c'hentaÃ	|	      ** Breizh ha Linux atav! **
Jef		|		http://moinejf.free.fr/
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html