Hi, thank you for the review, I agree with you on all the suggested changes except on this one: On 25 May 2011 10:05, Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> wrote: > Hi Javier, > > Thanks for the patch. Here's a review of the power handling code. > > On Tuesday 24 May 2011 16:30:43 Javier Martin wrote: >> This RFC includes a power management implementation that causes >> the sensor to show images with horizontal artifacts (usually >> monochrome lines that appear on the image randomly). >> >> Signed-off-by: Javier Martin <javier.martin@xxxxxxxxxxxxxxxxx> > > [snip] > >> diff --git a/drivers/media/video/mt9p031.c b/drivers/media/video/mt9p031.c >> new file mode 100644 >> index 0000000..04d8812 >> --- /dev/null >> +++ b/drivers/media/video/mt9p031.c > > [snip] >> +#define MT9P031_WINDOW_HEIGHT_MAX 1944 >> +#define MT9P031_WINDOW_WIDTH_MAX 2592 >> +#define MT9P031_WINDOW_HEIGHT_MIN 2 >> +#define MT9P031_WINDOW_WIDTH_MIN 18 > > Can you move those 4 constants right below MT9P031_WINDOW_HEIGHT and > MT9P031_WINDOW_WIDTH ? The max values are not correct, according to the > datasheet they should be 2005 and 2751. In figure 4, it says active image size is 2592 x 1944 Why should I include active boundary and dark pixels? -- Javier Martin Vista Silicon S.L. CDTUC - FASE C - Oficina S-345 Avda de los Castros s/n 39005- Santander. Cantabria. Spain +34 942 25 32 60 www.vista-silicon.com -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
