On Monday 23 May 2011 20:22:02 Guennadi Liakhovetski wrote: > Please, inline patches. Otherwise, this is what one gets, when replying. > > On Mon, 23 May 2011, Hans Petter Selasky wrote: > > --HPS > > In any case, just throwing in my 2 cents - no idea how not using the > return value of WARN() makes code more readable. On the contrary, using it > is a standard practice. This patch doesn't seem like an improvement to me. There is no strong reason for the WARN() part, you may ignore that, but the ret = 0, part is still valid. Should I generate a new patch or can you handle this? --HPS -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html