RE: [PATCH v17 5/6] davinci vpbe: Build infrastructure for VPBE driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, May 20, 2011 at 20:02:08, Sergei Shtylyov wrote:
> Hello.
> 
> Manjunath Hadli wrote:
> 
> > This patch adds the build infra-structure for Davinci
> > VPBE dislay driver.
> 
> > Signed-off-by: Manjunath Hadli <manjunath.hadli@xxxxxx>
> > Acked-by: Muralidharan Karicheri <m-karicheri2@xxxxxx>
> > Acked-by: Hans Verkuil <hverkuil@xxxxxxxxx>
> [...]
> 
> > diff --git a/drivers/media/video/davinci/Kconfig b/drivers/media/video/davinci/Kconfig
> > index 6b19540..a7f11e7 100644
> > --- a/drivers/media/video/davinci/Kconfig
> > +++ b/drivers/media/video/davinci/Kconfig
> > @@ -91,3 +91,25 @@ config VIDEO_ISIF
> >  
> >  	   To compile this driver as a module, choose M here: the
> >  	   module will be called vpfe.
> > +
> > +config VIDEO_DM644X_VPBE
> > +	tristate "DM644X VPBE HW module"
> 
>     BTW, as this seems DM644x specific, shouldn't this depend on 
> CONFIG_ARCH_DAVINCI_DM644x?

Since VENC/OSD etc are also applicable to other
DaVinci devices, this KConfig entry should probably
be split to refer to them individually and in a generic
way. "depends on" can then be used to make sure only
the relevant ones show up.

Thanks,
Sekhar

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux